diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-10-17 10:26:26 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-10-19 14:51:34 +0200 |
| commit | 50beeb680949117017343e593dd7323632a6d872 (patch) | |
| tree | f31c97c58d73df363f17f6cbf2a874cfa48d6c05 /scripts/coccinelle/use-error_fatal.cocci | |
| parent | 4b5766488fd3549dc47a75331cf4db62f477536c (diff) | |
| download | focaccia-qemu-50beeb680949117017343e593dd7323632a6d872.tar.gz focaccia-qemu-50beeb680949117017343e593dd7323632a6d872.zip | |
Use error_fatal to simplify obvious fatal errors (again)
Add a slight improvement of the Coccinelle semantic patch from commit 007b06578ab, and use it to clean up. It leaves dead Error * variables behind, cleaned up manually. Cc: David Gibson <david@gibson.dropbear.id.au> Cc: Alexander Graf <agraf@suse.de> Cc: Eric Blake <eblake@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-Id: <20181017082702.5581-3-armbru@redhat.com>
Diffstat (limited to 'scripts/coccinelle/use-error_fatal.cocci')
| -rw-r--r-- | scripts/coccinelle/use-error_fatal.cocci | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/scripts/coccinelle/use-error_fatal.cocci b/scripts/coccinelle/use-error_fatal.cocci new file mode 100644 index 0000000000..10fff0aec4 --- /dev/null +++ b/scripts/coccinelle/use-error_fatal.cocci @@ -0,0 +1,20 @@ +@@ +type T; +identifier FUN, RET; +expression list ARGS; +expression ERR, EC, FAIL; +@@ +( +- T RET = FUN(ARGS, &ERR); ++ T RET = FUN(ARGS, &error_fatal); +| +- RET = FUN(ARGS, &ERR); ++ RET = FUN(ARGS, &error_fatal); +| +- FUN(ARGS, &ERR); ++ FUN(ARGS, &error_fatal); +) +- if (FAIL) { +- error_report_err(ERR); +- exit(EC); +- } |