summary refs log tree commit diff stats
path: root/scripts/qapi-introspect.py
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-12-02 21:20:33 +0100
committerAndreas Färber <afaerber@suse.de>2015-12-04 18:25:42 +0100
commit041088c71934b8991c21b61bd4ee91d76a6f2b07 (patch)
tree5c95c0d8a091f3049114984c21ec23c3e1999d57 /scripts/qapi-introspect.py
parent70ae0b6d0e7968a9ac1b85acb5697a6950654bf4 (diff)
downloadfocaccia-qemu-041088c71934b8991c21b61bd4ee91d76a6f2b07.tar.gz
focaccia-qemu-041088c71934b8991c21b61bd4ee91d76a6f2b07.zip
tests: Use proper functions types instead of void (*fn)
We have several function parameters declared as void (*fn).  This is
just a stupid way to write void *, and the only purpose writing it
like that could serve is obscuring the sin of bypassing the type
system without need.

The original sin is commit 49ee359: its qtest_add_func() is a wrapper
for g_test_add_func().  Fix the parameter type to match
g_test_add_func()'s.  This uncovers type errors in ide-test.c; fix
them.

Commit 7949c0e faithfully repeated the sin for qtest_add_data_func().
Fix it the same way, along with a harmless type error uncovered in
vhost-user-test.c.

Commit 063c23d repeated it for qtest_add_abrt_handler().  The screwy
parameter gets assigned to GHook member func, so change its type to
match.  Requires wrapping kill_qemu() to keep the type checker happy.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[AF/armbru: Inline GTestFunc/GTestDataFunc typedef for old GLib]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'scripts/qapi-introspect.py')
0 files changed, 0 insertions, 0 deletions