summary refs log tree commit diff stats
path: root/scripts/qapi.py
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2017-03-03 15:50:31 +0000
committerPeter Maydell <peter.maydell@linaro.org>2017-03-07 14:33:51 +0000
commit1d153a3388b150b8aeedde32242db86b79c45473 (patch)
tree64fe1731167f5d3c143b0f40b318b23fbc2a6148 /scripts/qapi.py
parent2e3883d03df167b15f2acc5345eb9a7e0150a062 (diff)
downloadfocaccia-qemu-1d153a3388b150b8aeedde32242db86b79c45473.tar.gz
focaccia-qemu-1d153a3388b150b8aeedde32242db86b79c45473.zip
disas/microblaze: Avoid unintended sign extension
In read_insn_microblaze() we assemble 4 bytes into an 'unsigned
long'.  If 'unsigned long' is 64 bits and the high byte has its top
bit set, then C's implicit conversion from 'unsigned char' to 'int'
for the shift will result in an unintended sign extension which sets
the top 32 bits in 'inst'.  Add casts to prevent this.  (Spotted by
Coverity, CID 1005401.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Message-id: 1488556233-31246-5-git-send-email-peter.maydell@linaro.org
Diffstat (limited to 'scripts/qapi.py')
0 files changed, 0 insertions, 0 deletions