diff options
| author | Cédric Le Goater <clg@kaod.org> | 2020-04-04 17:36:55 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2020-04-07 08:55:11 +1000 |
| commit | 25f3170b06544e4de620336da5b2ea3b392d66bc (patch) | |
| tree | 64ade8e1e2865a3d5d85ad6e2b9df6601b73889d /scripts/qapi/commands.py | |
| parent | a872e4328bb3c2dda0699e04abf0f902950221f3 (diff) | |
| download | focaccia-qemu-25f3170b06544e4de620336da5b2ea3b392d66bc.tar.gz focaccia-qemu-25f3170b06544e4de620336da5b2ea3b392d66bc.zip | |
ppc/pnv: Create BMC devices only when defaults are enabled
Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
introduced default BMC devices which can be a problem when the same
devices are defined on the command line with :
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
QEMU fails with :
qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS
Use defaults_enabled() when creating the default BMC devices to let
the user provide its own BMC devices using '-nodefaults'. If no BMC
device are provided, output a warning but let QEMU run as this is a
supported configuration. However, when multiple BMC devices are
defined, stop QEMU with a clear error as the results are unexpected.
Fixes: e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20200404153655.166834-1-clg@kaod.org>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'scripts/qapi/commands.py')
0 files changed, 0 insertions, 0 deletions