summary refs log tree commit diff stats
path: root/scripts/qapi/common.py
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2018-04-11 19:46:06 +0200
committerDavid Gibson <david@gibson.dropbear.id.au>2018-04-27 18:05:22 +1000
commit1d36c75a9ebf6bddbdb46693052a48ef134f3699 (patch)
tree43c494c56da32e2ee4b329d666d9d6e1238de980 /scripts/qapi/common.py
parent2b10808539d7ace3d9b1226a71a68e2431ef2176 (diff)
downloadfocaccia-qemu-1d36c75a9ebf6bddbdb46693052a48ef134f3699.tar.gz
focaccia-qemu-1d36c75a9ebf6bddbdb46693052a48ef134f3699.zip
spapr: drop useless sanity check in spapr_irq_alloc*()
Both spapr_irq_alloc() and spapr_irq_alloc_block() have an errp
parameter, but they don't use it if XICS hasn't been initialized
yet.

This is doubly wrong:

- all callers do pass a non-null Error **, ie, they expect an error
  to be propagated in case of failure

- XICS obviously needs to be initialized before anything starts allocating
  IRQs

So this patch turns the check into an assert.

Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'scripts/qapi/common.py')
0 files changed, 0 insertions, 0 deletions