summary refs log tree commit diff stats
path: root/scripts/qapi/error.py
diff options
context:
space:
mode:
authorDr. David Alan Gilbert <dgilbert@redhat.com>2020-08-24 11:29:14 +0100
committerKevin Wolf <kwolf@redhat.com>2020-10-02 15:46:40 +0200
commitda16f4b867e494b0a73ec74555804209c819d2f8 (patch)
treef87253ba6dec2e116c5b3e0840948c9ccc881633 /scripts/qapi/error.py
parent8e7b122bf85e114c1e94443f82244675bbe3d1f3 (diff)
downloadfocaccia-qemu-da16f4b867e494b0a73ec74555804209c819d2f8.tar.gz
focaccia-qemu-da16f4b867e494b0a73ec74555804209c819d2f8.zip
qemu-io-cmds: Simplify help_oneline
help_oneline is declared and starts as:

  static void help_oneline(const char *cmd, const cmdinfo_t *ct)
  {
      if (cmd) {
          printf("%s ", cmd);
      } else {
          printf("%s ", ct->name);
          if (ct->altname) {
              printf("(or %s) ", ct->altname);
          }
      }

However, there are only two routes to help_oneline being called:

   help_f -> help_all -> help_oneline(ct->name, ct)

   help_f -> help_onecmd(argv[1], ct)

In the first case, 'cmd' and 'ct->name' are the same thing,
so it's impossible for the if (cmd) to be false and then validly
print ct->name - this is upsetting gcc
( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96739 )

In the second case, cmd is argv[1] and we know we've got argv[1]
so again (cmd) is non-NULL.

Simplify help_oneline by just printing cmd.
(Also strengthen argc check just to be pedantic)

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200824102914.105619-1-dgilbert@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/qapi/error.py')
0 files changed, 0 insertions, 0 deletions