diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-07-14 18:01:59 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2020-07-17 10:44:23 +0200 |
| commit | ab2d185d6b1d3aa1ab2416a896347d235e32ac3d (patch) | |
| tree | cf9db2dff6eb715b4524f6666f836839d81a1baa /scripts/qapi/parser.py | |
| parent | 12a9b8d8240aaddf14774b9fb03af5e2e0b9f60a (diff) | |
| download | focaccia-qemu-ab2d185d6b1d3aa1ab2416a896347d235e32ac3d.tar.gz focaccia-qemu-ab2d185d6b1d3aa1ab2416a896347d235e32ac3d.zip | |
qom: Plug memory leak in "info qom-tree"
Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted"
created a memory leak, because I didn't realize
object_get_canonical_path_component()'s value needs to be freed.
Reproducer:
$ qemu-system-x86_64 -nodefaults -display none -S -monitor stdio
QEMU 5.0.50 monitor - type 'help' for more information
(qemu) info qom-tree
This leaks some 4500 path components, 12-13 characters on average,
i.e. roughly 100kBytes depending on the allocator. A couple of
hundred "info qom-tree" here, a couple of hundred there, and soon
enough we're talking about real memory.
Plug the leak.
Fixes: e8c9e65816f5dbfe18ad3b2be938d0d8192d459a
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reported-by: Reviewed-by: Li Qiang <liq3ea@gmail.com> [sent same patch]
Message-Id: <20200714160202.3121879-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions