summary refs log tree commit diff stats
path: root/scripts/qapi/source.py
diff options
context:
space:
mode:
authorBernhard Beschow <shentey@gmail.com>2023-07-09 10:09:50 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2023-07-25 14:40:49 +0200
commit3b830790151ff231531ef2595793e387dd154efb (patch)
tree5525c2dbb2ae540d041d9ce7c3859b5a176a80a2 /scripts/qapi/source.py
parent3ee44ec72753ec0ff05ad1569dfa609203d722b2 (diff)
downloadfocaccia-qemu-3b830790151ff231531ef2595793e387dd154efb.tar.gz
focaccia-qemu-3b830790151ff231531ef2595793e387dd154efb.zip
hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers
Since commit c0a55a0c9da2 "hw/sd/sdhci: Support big endian SD host controller
interfaces" sdhci_common_realize() forces all SD card controllers to use either
sdhci_mmio_le_ops or sdhci_mmio_be_ops, depending on the "endianness" property.
However, there are device models which use different MMIO ops: TYPE_IMX_USDHC
uses usdhc_mmio_ops and TYPE_S3C_SDHCI uses sdhci_s3c_mmio_ops.

Forcing sdhci_mmio_le_ops breaks SD card handling on the "sabrelite" board, for
example. Fix this by defaulting the io_ops to little endian and switch to big
endian in sdhci_common_realize() only if there is a matchig big endian variant
available.

Fixes: c0a55a0c9da2 ("hw/sd/sdhci: Support big endian SD host controller
interfaces")

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Message-Id: <20230709080950.92489-1-shentey@gmail.com>
Diffstat (limited to 'scripts/qapi/source.py')
0 files changed, 0 insertions, 0 deletions