summary refs log tree commit diff stats
path: root/scripts/qapi/source.py
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2021-04-07 16:34:58 +0200
committerMichael S. Tsirkin <mst@redhat.com>2021-05-14 10:26:18 -0400
commit570fe439e5d1b8626cf344c6bc97d90cfcaf0c79 (patch)
tree74766593863f2dbe7dc62286a8426a7bed345549 /scripts/qapi/source.py
parent8a49487c654a6150615d758e0816314b00cb481e (diff)
downloadfocaccia-qemu-570fe439e5d1b8626cf344c6bc97d90cfcaf0c79.tar.gz
focaccia-qemu-570fe439e5d1b8626cf344c6bc97d90cfcaf0c79.zip
virtio-blk: Fix rollback path in virtio_blk_data_plane_start()
When dataplane multiqueue support was added in QEMU 2.7, the path
that would rollback guest notifiers assignment in case of error
simply got dropped.

Later on, when Error was added to blk_set_aio_context() in QEMU 4.1,
another error path was introduced, but it ommits to rollback both
host and guest notifiers.

It seems cleaner to fix the rollback path in one go. The patch is
simple enough that it can be adjusted if backported to a pre-4.1
QEMU.

Fixes: 51b04ac5c6a6 ("virtio-blk: dataplane multiqueue support")
Cc: stefanha@redhat.com
Fixes: 97896a4887a0 ("block: Add Error to blk_set_aio_context()")
Cc: kwolf@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20210407143501.244343-2-groug@kaod.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/qapi/source.py')
0 files changed, 0 insertions, 0 deletions