diff options
| author | John Snow <jsnow@redhat.com> | 2021-02-15 21:17:55 -0500 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2021-02-18 19:37:28 +0100 |
| commit | 055569603d150a18e4d976bb58092206f5024814 (patch) | |
| tree | 3263039fb7a1f8f347a2448dc3b19cbe39d31e94 /scripts/qapi/types.py | |
| parent | 84bece7dd4ce7ca5a36bc996452ebc882f59ae54 (diff) | |
| download | focaccia-qemu-055569603d150a18e4d976bb58092206f5024814.tar.gz focaccia-qemu-055569603d150a18e4d976bb58092206f5024814.zip | |
qapi/introspect.py: guard against ifcond/comment misuse
_tree_to_qlit is called recursively on dict values (isolated from their keys); at such a point in generating output it is too late to apply an ifcond. Similarly, comments do not necessarily have a "tidy" place they can be printed in such a circumstance. Forbid this usage by renaming "suppress_first_indent" to "dict_value" to emphasize that indents are suppressed only for the benefit of dict values; then add an assertion assuring we do not pass ifcond/comments in this case. Signed-off-by: John Snow <jsnow@redhat.com> Message-Id: <20210216021809.134886-6-jsnow@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Comment wrapped to conform to PEP 8] Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts/qapi/types.py')
0 files changed, 0 insertions, 0 deletions