summary refs log tree commit diff stats
path: root/scripts/qapi
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2019-02-01 14:55:45 +0000
committerPeter Maydell <peter.maydell@linaro.org>2019-02-01 14:55:45 +0000
commiteaefb97a8b97dbf42c016fe65b68b92f99a346f6 (patch)
tree47de13116ddfb1a84ef887a833aaf609221478a8 /scripts/qapi
parent4dfabb6d568e6b315594d7d464dacaf3368aff60 (diff)
downloadfocaccia-qemu-eaefb97a8b97dbf42c016fe65b68b92f99a346f6.tar.gz
focaccia-qemu-eaefb97a8b97dbf42c016fe65b68b92f99a346f6.zip
target/arm/translate-a64: Fix mishandling of size in FCMLA decode
In disas_simd_indexed(), for the case of "complex fp", each indexable
element is a complex pair, so the total size is twice that indicated
in the 'size' field in the encoding. We were trying to do this
"double the size" operation with a left shift by 1, but this is
incorrect because the 'size' field is a MO_8/MO_16/MO_32/MO_64
value, and doubling the size should be done by a simple increment.

This meant we were mishandling FCMLA (by element) of values where
the real and imaginary parts are 32-bit floats, and would incorrectly
UNDEF this encoding. (No other insns take this code path, and for
16-bit floats it happens that 1 << 1 and 1 + 1 are both the same).

Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Message-id: 20190129140411.682-3-peter.maydell@linaro.org
Diffstat (limited to 'scripts/qapi')
0 files changed, 0 insertions, 0 deletions