summary refs log tree commit diff stats
path: root/scripts/qemugdb/mtree.py
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2015-09-01 23:33:23 +0200
committerMichael S. Tsirkin <mst@redhat.com>2015-09-10 12:15:30 +0300
commit0f288f854b96f56247e38f4207f71647133f0184 (patch)
treef0fc8c4a58065ae806f6b733ba38a8d3ede69b9b /scripts/qemugdb/mtree.py
parent2f8b50083b321e470ef8e2502910ade40cbfa020 (diff)
downloadfocaccia-qemu-0f288f854b96f56247e38f4207f71647133f0184.tar.gz
focaccia-qemu-0f288f854b96f56247e38f4207f71647133f0184.zip
hw/pci: fix pci_update_mappings() trace events
The current trace prototypes and (matching) trace calls lead to
"unorthodox" PCI BDF notation in at least the stderr trace backend. For
example, the four BARs of a QXL video card at 00:01.0 (bus 0, slot 1,
function 0) are traced like this (PID and timestamps removed):

  pci_update_mappings_add d=0x7f14a73bf890 00:00.1 0,0x84000000+0x4000000
  pci_update_mappings_add d=0x7f14a73bf890 00:00.1 1,0x80000000+0x4000000
  pci_update_mappings_add d=0x7f14a73bf890 00:00.1 2,0x88200000+0x2000
  pci_update_mappings_add d=0x7f14a73bf890 00:00.1 3,0xd060+0x20

The slot and function values are in reverse order.

Stick with the conventional BDF notation.

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Don Koch <dkoch@verizon.com>
Cc: qemu-trivial@nongnu.org
Fixes: 7828d75045
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/qemugdb/mtree.py')
0 files changed, 0 insertions, 0 deletions