diff options
| author | Bharata B Rao <bharata@linux.vnet.ibm.com> | 2016-08-03 13:08:23 +1000 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2016-08-03 13:08:54 +1000 |
| commit | c8721d35994fd3731e592f81ba2f9c08e7dc8c31 (patch) | |
| tree | eb768ae75aec96ea17e740da326d60fba88f7aa8 /scripts/signrom.py | |
| parent | 8b54a6a6c63dc84f2744f6b125c1a6c5a16ee10b (diff) | |
| download | focaccia-qemu-c8721d35994fd3731e592f81ba2f9c08e7dc8c31.tar.gz focaccia-qemu-c8721d35994fd3731e592f81ba2f9c08e7dc8c31.zip | |
spapr: Error out when CPU hotplug is attempted on older pseries machines
CPU hotplug and coldplug aren't supported prior to pseries-2.7. Further, earlier machine types don't use CPU core objects at all. These mean that query-hotpluggable-cpus and coldplug on older pseries machines will crash QEMU. It also means that hotpluggable_cpus flag in query-machines will be incorrectly set to true for pseries < 2.7, since it is based on the presence of the query_hotpluggable_cpus hook. - Don't assign the query_hotpluggable_cpus hook for pseries < 2.7 - query_hotpluggable_cpus should therefore never be called on pseries < 2.7, so add an assert - spapr_core_pre_plug() should fail hot/cold plug attempts for pseries < 2.7, since core objects are never used there - spapr_core_plug() should therefore never be called for pseries < 2.7, so add an assert. Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com> [dwg: Change from query_hotpluggable_cpus returning NULL for pseries < 2.7 to not being called at all, reword commit message for accuracy] Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'scripts/signrom.py')
0 files changed, 0 insertions, 0 deletions