summary refs log tree commit diff stats
path: root/scripts/tracetool/backend/log.py
diff options
context:
space:
mode:
authorGreg Kurz <gkurz@linux.vnet.ibm.com>2016-02-05 11:46:04 +0100
committerMichael S. Tsirkin <mst@redhat.com>2016-02-16 12:05:18 +0200
commit46f70ff148ae01e2dc96e64c393e295a0092555d (patch)
tree68417b8f64f7019d9a7fd488f6d4ba858accb3b3 /scripts/tracetool/backend/log.py
parente58481234ef9c132554cc529d9981ebd78fb6903 (diff)
downloadfocaccia-qemu-46f70ff148ae01e2dc96e64c393e295a0092555d.tar.gz
focaccia-qemu-46f70ff148ae01e2dc96e64c393e295a0092555d.zip
vhost: simplify vhost_needs_vring_endian()
After the call to virtio_vdev_has_feature(), we only care for legacy
devices, so we don't need the extra check in virtio_is_big_endian().

Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN
may only happen on a virtio_load() path that cannot lead here), so we
don't need the assert() either.

This open codes the device_endian checking in vhost_needs_vring_endian().
It also adds a comment to explain the logic, as recent reviews showed the
cross-endian tweaks aren't that obvious.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'scripts/tracetool/backend/log.py')
0 files changed, 0 insertions, 0 deletions