diff options
| author | Markus Armbruster <armbru@redhat.com> | 2022-11-22 14:49:16 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2022-12-14 16:19:35 +0100 |
| commit | 66997c42e02c84481fc162a5b7bd6ad6c643bae2 (patch) | |
| tree | 889d4e08622f178c74334c3317ccc8a0ca8431c3 /scripts | |
| parent | 10220d2f96406463fc283a3de6b13fc38f8befff (diff) | |
| download | focaccia-qemu-66997c42e02c84481fc162a5b7bd6ad6c643bae2.tar.gz focaccia-qemu-66997c42e02c84481fc162a5b7bd6ad6c643bae2.zip | |
cleanup: Tweak and re-run return_directly.cocci
Tweak the semantic patch to drop redundant parenthesis around the return expression. Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored manually. Coccinelle messes up vmdk_co_create(), not sure why. Change dropped, will be done manually in the next commit. Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up manually. Whitespace in tools/virtiofsd/fuse_lowlevel.c tidied up manually. checkpatch.pl complains "return of an errno should typically be -ve" two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes it visible to checkpatch.pl. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20221122134917.1217307-2-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/coccinelle/return_directly.cocci | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci index 4cf50e75ea..6cb1b3c99a 100644 --- a/scripts/coccinelle/return_directly.cocci +++ b/scripts/coccinelle/return_directly.cocci @@ -11,9 +11,8 @@ identifier F; - T VAR; ... when != VAR -- VAR = -+ return - E; +- VAR = (E); - return VAR; ++ return E; ... when != VAR } |