diff options
| author | Samuel Thibault <samuel.thibault@gnu.org> | 2014-05-14 03:13:09 +0200 |
|---|---|---|
| committer | Edgar E. Iglesias <edgar.iglesias@xilinx.com> | 2014-06-09 01:49:28 +0200 |
| commit | 959e41473f2179850578482052fb73b913bc4e42 (patch) | |
| tree | 03242d926a2e182aeabe4ba81735d2a97f70a196 /slirp/slirp.c | |
| parent | 37654d9e6af84003982f8b9a5d59a4aef28e0a79 (diff) | |
| download | focaccia-qemu-959e41473f2179850578482052fb73b913bc4e42.tar.gz focaccia-qemu-959e41473f2179850578482052fb73b913bc4e42.zip | |
slirp/arp: do not special-case bogus IP addresses
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Silently avoid having 0.0.0.0 as a destination, however. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> [Edgar: Minor change to subject] Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Diffstat (limited to 'slirp/slirp.c')
| -rw-r--r-- | slirp/slirp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/slirp/slirp.c b/slirp/slirp.c index 3fb48a4921..60280361e6 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -778,6 +778,11 @@ int if_encap(Slirp *slirp, struct mbuf *ifm) return 1; } + if (iph->ip_dst.s_addr == 0) { + /* 0.0.0.0 can not be a destination address, something went wrong, + * avoid making it worse */ + return 1; + } if (!arp_table_search(slirp, iph->ip_dst.s_addr, ethaddr)) { uint8_t arp_req[ETH_HLEN + sizeof(struct arphdr)]; struct ethhdr *reh = (struct ethhdr *)arp_req; |