summary refs log tree commit diff stats
path: root/stubs/error-printf.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2016-10-14 10:00:54 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2016-10-31 19:21:22 -0500
commitf06b2031a31cdd3acf6f61a977e505b8c6b58f73 (patch)
treeca7570d52247f66c31e0aef5bd6a2e207cebf6c6 /stubs/error-printf.c
parentb8093d38e8dce0413fe8999fe2dee48a96ab1104 (diff)
downloadfocaccia-qemu-f06b2031a31cdd3acf6f61a977e505b8c6b58f73.tar.gz
focaccia-qemu-f06b2031a31cdd3acf6f61a977e505b8c6b58f73.zip
qga: drop unnecessary GA_CHANNEL_UNIX_LISTEN checks
Throughout the code there are c->listen_channel checks which manage the
listen socket file descriptor (waiting for accept(2), closing the file
descriptor, etc).  These checks are currently preceded by explicit
c->method == GA_CHANNEL_UNIX_LISTEN checks.

Explicit GA_CHANNEL_UNIX_LISTEN checks are not necessary since serial
channel types do not create the listen channel (c->listen_channel).

As more listen channel types are added, explicitly checking all of them
becomes messy.  Rely on c->listen_channel to determine whether or not a
listen socket file descriptor is used.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'stubs/error-printf.c')
0 files changed, 0 insertions, 0 deletions