summary refs log tree commit diff stats
path: root/stubs/monitor-i386-rtc.c
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2025-05-22 12:05:28 -0700
committerMarkus Armbruster <armbru@redhat.com>2025-05-28 18:26:23 +0200
commita78a91feeea66270badd87c65a7236e90baa5984 (patch)
tree5ee337278be603245074f33add50978674e4fb47 /stubs/monitor-i386-rtc.c
parent80db93b2b88f9b3ed8927ae7ac74ca30e643a83e (diff)
downloadfocaccia-qemu-a78a91feeea66270badd87c65a7236e90baa5984.tar.gz
focaccia-qemu-a78a91feeea66270badd87c65a7236e90baa5984.zip
qapi: expose rtc-reset-reinjection command unconditionally
This removes the TARGET_I386 condition from the rtc-reset-reinjection
command. This requires providing a QMP command stub for non-i386 target.
This in turn requires moving the command out of misc-target.json, since
that will trigger symbol poisoning errors when built from target
independent code.

Rather than putting the command into misc.json, it is proposed to create
misc-$TARGET.json files to hold commands whose impl is conceptually
only applicable to a single target. This gives an obvious docs hint to
consumers that the command is only useful in relation a specific target,
while misc.json is for commands applicable to 2 or more targets.

The current impl of qmp_rtc_reset_reinject() is a no-op if the i386
RTC is disabled in Kconfig, or if the running machine type lack any
RTC device.

The stub impl for non-i386 targets retains this no-op behaviour.
However, it is now reporting an Error mentioning this command is not
available for current target.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20250522190542.588267-2-pierrick.bouvier@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'stubs/monitor-i386-rtc.c')
-rw-r--r--stubs/monitor-i386-rtc.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/stubs/monitor-i386-rtc.c b/stubs/monitor-i386-rtc.c
new file mode 100644
index 0000000000..8420d7c93c
--- /dev/null
+++ b/stubs/monitor-i386-rtc.c
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include "qemu/osdep.h"
+#include "qapi/error.h"
+#include "qapi/qapi-commands-misc-i386.h"
+
+void qmp_rtc_reset_reinjection(Error **errp)
+{
+    error_setg(errp,
+               "RTC interrupt reinjection backlog reset is not available for"
+               "this machine");
+}