summary refs log tree commit diff stats
path: root/system/cpus.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2025-08-29 11:26:05 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2025-09-17 19:00:55 +0200
commit27e76d010104646c997d20ca0996fb5a046587b0 (patch)
treeed37640209e6666425cd1251101cc28214bd1e75 /system/cpus.c
parent602d5ebba26b245730a0b6a4855b1812d587725c (diff)
downloadfocaccia-qemu-27e76d010104646c997d20ca0996fb5a046587b0.tar.gz
focaccia-qemu-27e76d010104646c997d20ca0996fb5a046587b0.zip
cpu-common: use atomic access for interrupt_request
Writes to interrupt_request used non-atomic accesses, but there are a
few cases where the access was not protected by the BQL.  Now that
there is a full set of helpers, it's easier to guarantee that
interrupt_request accesses are fully atomic, so just drop the
requirement instead of fixing them.

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'system/cpus.c')
-rw-r--r--system/cpus.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/system/cpus.c b/system/cpus.c
index 437848b5eb..9bfbe2b060 100644
--- a/system/cpus.c
+++ b/system/cpus.c
@@ -257,8 +257,7 @@ int64_t cpus_get_elapsed_ticks(void)
 void cpu_set_interrupt(CPUState *cpu, int mask)
 {
     /* Pairs with cpu_test_interrupt(). */
-    qatomic_store_release(&cpu->interrupt_request,
-        cpu->interrupt_request | mask);
+    qatomic_or(&cpu->interrupt_request, mask);
 }
 
 void generic_handle_interrupt(CPUState *cpu, int mask)