diff options
| author | Peter Xu <peterx@redhat.com> | 2024-10-24 17:30:53 -0400 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-10-31 15:48:18 -0400 |
| commit | 34a8892decdcec13d641f57bcb2a9c35fbc4c07b (patch) | |
| tree | 5a057942e618bc129cf61cc62d056ea615740289 /system/qdev-monitor.c | |
| parent | f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf (diff) | |
| download | focaccia-qemu-34a8892decdcec13d641f57bcb2a9c35fbc4c07b.tar.gz focaccia-qemu-34a8892decdcec13d641f57bcb2a9c35fbc4c07b.zip | |
migration: Drop migration_is_idle()
Now with the current migration_is_running(), it will report exactly the opposite of what will be reported by migration_is_idle(). Drop migration_is_idle(), instead use "!migration_is_running()" which should be identical on functionality. In reality, most of the idle check is inverted, so it's even easier to write with "migrate_is_running()" check. Reviewed-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20241024213056.1395400-6-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'system/qdev-monitor.c')
| -rw-r--r-- | system/qdev-monitor.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 44994ea0e1..320c47b72d 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -679,7 +679,7 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts, return NULL; } - if (!migration_is_idle()) { + if (migration_is_running()) { error_setg(errp, "device_add not allowed while migrating"); return NULL; } @@ -928,7 +928,7 @@ void qdev_unplug(DeviceState *dev, Error **errp) return; } - if (!migration_is_idle() && !dev->allow_unplug_during_migration) { + if (migration_is_running() && !dev->allow_unplug_during_migration) { error_setg(errp, "device_del not allowed while migrating"); return; } |