diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2024-12-17 15:59:49 +0000 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2024-12-17 19:39:53 +0100 |
| commit | 37e9b19c34d9500164e33ccf377e1830e956bca0 (patch) | |
| tree | 4699be481053c51effb54772ffc6d81c965b3234 /tests/functional/test_ppc64_tuxrun.py | |
| parent | 3bb4c8b6134df5367675c4ade4f5c177d29fe903 (diff) | |
| download | focaccia-qemu-37e9b19c34d9500164e33ccf377e1830e956bca0.tar.gz focaccia-qemu-37e9b19c34d9500164e33ccf377e1830e956bca0.zip | |
tests/functional: replace 'run_cmd' with subprocess helpers
The 'run_cmd' helper is re-implementing a convenient helper that already exists in the form of the 'run' and 'check_call' methods provided by 'subprocess'. Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-ID: <20241217155953.3950506-29-berrange@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/functional/test_ppc64_tuxrun.py')
| -rwxr-xr-x | tests/functional/test_ppc64_tuxrun.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/tests/functional/test_ppc64_tuxrun.py b/tests/functional/test_ppc64_tuxrun.py index 03b47e07f2..8a98d18ab3 100755 --- a/tests/functional/test_ppc64_tuxrun.py +++ b/tests/functional/test_ppc64_tuxrun.py @@ -11,9 +11,10 @@ # # SPDX-License-Identifier: GPL-2.0-or-later +from subprocess import check_call, DEVNULL import tempfile -from qemu_test import run_cmd, Asset +from qemu_test import Asset from qemu_test.tuxruntest import TuxRunBaselineTest class TuxRunPPC64Test(TuxRunBaselineTest): @@ -70,7 +71,9 @@ class TuxRunPPC64Test(TuxRunBaselineTest): # Create a temporary qcow2 and launch the test-case with tempfile.NamedTemporaryFile(prefix=prefix, suffix='.qcow2') as qcow2: - run_cmd([self.qemu_img, 'create', '-f', 'qcow2', qcow2.name, ' 1G']) + check_call([self.qemu_img, 'create', '-f', 'qcow2', + qcow2.name, ' 1G'], + stdout=DEVNULL, stderr=DEVNULL) self.vm.add_args('-drive', 'file=' + qcow2.name + ',format=qcow2,if=none,id=' |