summary refs log tree commit diff stats
path: root/tests/test-string-output-visitor.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2018-08-17 14:58:49 +0200
committerKevin Wolf <kwolf@redhat.com>2018-09-25 15:50:15 +0200
commitde0fbe64806321fc3e6399bfab360553db87a41d (patch)
tree8a9a8c219b3ea06f07aaaf5667350f3c75008c1e /tests/test-string-output-visitor.c
parent30c070a547322a5e41ce129d540bca3653b1a9c8 (diff)
downloadfocaccia-qemu-de0fbe64806321fc3e6399bfab360553db87a41d.tar.gz
focaccia-qemu-de0fbe64806321fc3e6399bfab360553db87a41d.zip
job: Use AIO_WAIT_WHILE() in job_finish_sync()
job_finish_sync() needs to release the AioContext lock of the job before
calling aio_poll(). Otherwise, callbacks called by aio_poll() would
possibly take the lock a second time and run into a deadlock with a
nested AIO_WAIT_WHILE() call.

Also, job_drain() without aio_poll() isn't necessarily enough to make
progress on a job, it could depend on bottom halves to be executed.

Combine both open-coded while loops into a single AIO_WAIT_WHILE() call
that solves both of these problems.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'tests/test-string-output-visitor.c')
0 files changed, 0 insertions, 0 deletions