summary refs log tree commit diff stats
path: root/tests/unit/test-smp-parse.c
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2024-05-29 14:19:19 +0800
committerThomas Huth <thuth@redhat.com>2024-06-12 12:10:57 +0200
commit7c56fb74b31fa697c7cdf634a141756b98771f08 (patch)
tree58615e63addf1b733443faa995b9dbdbb9b3fc20 /tests/unit/test-smp-parse.c
parent94aae6ed218e962095bfe37efe5ae5ca6f30d9a2 (diff)
downloadfocaccia-qemu-7c56fb74b31fa697c7cdf634a141756b98771f08.tar.gz
focaccia-qemu-7c56fb74b31fa697c7cdf634a141756b98771f08.zip
tests/unit/test-smp-parse: Fix comment of parameters=1 case
SMP_CONFIG_WITH_FULL_TOPO hasn't support module level, so the parameter
should indicate the "clusters".

Additionally, reorder the parameters of -smp to match the topology
hierarchy order.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Yongwei Ma <yongwei.ma@intel.com>
Message-ID: <20240529061925.350323-3-zhao1.liu@intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/unit/test-smp-parse.c')
-rw-r--r--tests/unit/test-smp-parse.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index fa8e7d83a7..c9cbc89c21 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -333,7 +333,9 @@ static const struct SMPTestData data_generic_valid[] = {
     }, {
         /*
          * Unsupported parameters are always allowed to be set to '1'
-         * config: -smp 8,books=1,drawers=1,sockets=2,modules=1,dies=1,cores=2,threads=2,maxcpus=8
+         * config:
+         *   -smp 8,drawers=1,books=1,sockets=2,dies=1,clusters=1,cores=2,\
+         *        threads=2,maxcpus=8
          * expect: cpus=8,sockets=2,cores=2,threads=2,maxcpus=8 */
         .config = SMP_CONFIG_WITH_FULL_TOPO(8, 1, 1, 2, 1, 1, 2, 2, 8),
         .expect_prefer_sockets = CPU_TOPOLOGY_GENERIC(8, 2, 2, 2, 8),