summary refs log tree commit diff stats
path: root/tests
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2016-02-23 14:14:33 -0700
committerMarkus Armbruster <armbru@redhat.com>2016-03-04 17:16:32 +0100
commit96a1616c85ae62fc13aff85a34effb4b2477b7ce (patch)
tree3a87d13bf2cc96c9a9fce68be7adb3c642606981 /tests
parente55250c6cb4cf836f9188095a21c85f663aac06b (diff)
downloadfocaccia-qemu-96a1616c85ae62fc13aff85a34effb4b2477b7ce.tar.gz
focaccia-qemu-96a1616c85ae62fc13aff85a34effb4b2477b7ce.zip
qapi-dealloc: Reduce use outside of generated code
No need to roll our own use of the dealloc visitors when we can
just directly use the qapi_free_FOO() functions that do what we
want in one line.

In net.c, inline net_visit() into its remaining lone caller.

After this patch, test-visitor-serialization.c is the only
non-generated file that needs to use a dealloc visitor, because
it is testing low level aspects of the visitor interface.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1456262075-3311-2-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/test-opts-visitor.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/tests/test-opts-visitor.c b/tests/test-opts-visitor.c
index b7acf7d294..297a02d6a2 100644
--- a/tests/test-opts-visitor.c
+++ b/tests/test-opts-visitor.c
@@ -17,7 +17,6 @@
 #include "qemu/option.h"          /* qemu_opts_parse() */
 #include "qapi/opts-visitor.h"    /* opts_visitor_new() */
 #include "test-qapi-visit.h"      /* visit_type_UserDefOptions() */
-#include "qapi/dealloc-visitor.h" /* qapi_dealloc_visitor_new() */
 
 static QemuOptsList userdef_opts = {
     .name = "userdef",
@@ -55,14 +54,7 @@ setup_fixture(OptsVisitorFixture *f, gconstpointer test_data)
 static void
 teardown_fixture(OptsVisitorFixture *f, gconstpointer test_data)
 {
-    if (f->userdef != NULL) {
-        QapiDeallocVisitor *dv;
-
-        dv = qapi_dealloc_visitor_new();
-        visit_type_UserDefOptions(qapi_dealloc_get_visitor(dv), NULL,
-                                  &f->userdef, NULL);
-        qapi_dealloc_visitor_cleanup(dv);
-    }
+    qapi_free_UserDefOptions(f->userdef);
     error_free(f->err);
 }