summary refs log tree commit diff stats
path: root/trace/control-target.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2017-07-07 07:44:58 -0500
committerKevin Wolf <kwolf@redhat.com>2017-07-10 13:18:07 +0200
commitc00716beb30ba996bd6fdfd5f41bb07e4414144f (patch)
treed6524217f3b3ecbc020b74f5e4d6de384bbb2db7 /trace/control-target.c
parentd6a644bbfef81bb6c7ab11656ad71e326f75ac77 (diff)
downloadfocaccia-qemu-c00716beb30ba996bd6fdfd5f41bb07e4414144f.tar.gz
focaccia-qemu-c00716beb30ba996bd6fdfd5f41bb07e4414144f.zip
block: Minimize raw use of bds->total_sectors
bdrv_is_allocated_above() was relying on intermediate->total_sectors,
which is a field that can have stale contents depending on the value
of intermediate->has_variable_length.  An audit shows that we are safe
(we were first calling through bdrv_co_get_block_status() which in
turn calls bdrv_nb_sectors() and therefore just refreshed the current
length), but it's nicer to favor our accessor functions to avoid having
to repeat such an audit, even if it means refresh_total_sectors() is
called more frequently.

Suggested-by: John Snow <jsnow@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'trace/control-target.c')
0 files changed, 0 insertions, 0 deletions