summary refs log tree commit diff stats
path: root/ui/input-linux.c
diff options
context:
space:
mode:
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>2016-04-09 12:25:12 +0100
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>2016-04-11 16:25:07 +0100
commit4553e10360a0713e31647220ed396942f9a6fca0 (patch)
treec7e45993f99ac463c921b27a6ff984bdde26e700 /ui/input-linux.c
parentdc1ffa66619b3661f17a309b0aa8d65d8d29583f (diff)
downloadfocaccia-qemu-4553e10360a0713e31647220ed396942f9a6fca0.tar.gz
focaccia-qemu-4553e10360a0713e31647220ed396942f9a6fca0.zip
target-sparc: fix ldstub sign-extension bug
ldstub [addr], reg incorrectly reads a signed byte from memory which causes
problems in the 32-bit Solaris mutex code. Here the byte value being read is
0xff which is incorrectly sign-extended to 0xffffffff before being written back
to the target register causing lock detection to behave incorrectly.

This fixes the intermittent hangs and MUTEX_HELD warnings issued to the
console when running 32-bit Solaris images under qemu-system-sparc.

With thanks to Joseph Dery for providing a condensed test image to consistently
reproduce the problem on demand, and Martin Husemann for allowing me access to
real hardware for comparison.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-By: Artyom Tarasenko <atar4qemu@gmail.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Diffstat (limited to 'ui/input-linux.c')
0 files changed, 0 insertions, 0 deletions