diff options
| author | Markus Armbruster <armbru@redhat.com> | 2025-09-23 11:09:56 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2025-09-30 14:43:54 +0200 |
| commit | b296b29d341429b82d9a76885f8e7fc3abd85ce2 (patch) | |
| tree | efe1b443a048d13514aa39cd83ae34f838e5bea6 /ui/qemu-pixman.c | |
| parent | 5bd58f04b831f7086f21ae70c90d1a86b6565762 (diff) | |
| download | focaccia-qemu-b296b29d341429b82d9a76885f8e7fc3abd85ce2.tar.gz focaccia-qemu-b296b29d341429b82d9a76885f8e7fc3abd85ce2.zip | |
ui/pixman: Consistent error handling in qemu_pixman_shareable_free()
qemu_pixman_shareable_free() wraps around either qemu_memfd_free() or qemu_win32_map_free(). The former reports trouble as error, with error_report(), then succeeds. The latter reports it as warning (we pass it &error_warn), then succeeds. Change the latter to report as error, too. Cc: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-ID: <20250923091000.3180122-10-armbru@redhat.com> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Diffstat (limited to 'ui/qemu-pixman.c')
| -rw-r--r-- | ui/qemu-pixman.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c index ef4e71da11..e46c6232cf 100644 --- a/ui/qemu-pixman.c +++ b/ui/qemu-pixman.c @@ -288,7 +288,10 @@ qemu_pixman_shareable_free(qemu_pixman_shareable handle, void *ptr, size_t size) { #ifdef WIN32 - qemu_win32_map_free(ptr, handle, &error_warn); + Error *err = NULL; + + qemu_win32_map_free(ptr, handle, &err); + error_report_err(err); #else qemu_memfd_free(ptr, size, handle); #endif |