summary refs log tree commit diff stats
path: root/ui/spice-input.c
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2017-06-02 12:15:19 +0400
committerMichael S. Tsirkin <mst@redhat.com>2017-06-08 22:02:36 +0300
commit277238f9f41e0a429a24b05c03f3010b35c3e9d0 (patch)
tree49836de6e617ae77f10ac9cd7d35f3b424dbd4b4 /ui/spice-input.c
parent64175afc695c0672876fbbfc31b299c86d562cb4 (diff)
downloadfocaccia-qemu-277238f9f41e0a429a24b05c03f3010b35c3e9d0.tar.gz
focaccia-qemu-277238f9f41e0a429a24b05c03f3010b35c3e9d0.zip
vhost-user-bridge: fix iov_restore_front() warning
  CC      tests/vhost-user-bridge.o
/home/dgilbert/git/qemu-world3/tests/vhost-user-bridge.c:228:23: warning: variables 'front' and 'iov' used in loop condition not modified in loop body [-Wfor-loop-analysis]
    for (cur = front; front != iov; cur++) {
                      ^~~~~    ~~~
1 warning generated.

Fix the loop, document the function, and fix some related assert().

In practice, the loop bug was harmless because the front sg buffer is
enough to discard/restore the header size.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Tested-by: Jens Freimann <jfreiman@redhat.com>
Diffstat (limited to 'ui/spice-input.c')
0 files changed, 0 insertions, 0 deletions