summary refs log tree commit diff stats
path: root/ui/spice-input.c
diff options
context:
space:
mode:
authorGreg Kurz <gkurz@linux.vnet.ibm.com>2016-02-25 12:08:00 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2016-02-28 16:19:02 +1100
commit3d0db3e74d818ba43c62cdfb3220e551f4f5ae37 (patch)
tree272bb5a6ac6a86abb545b6ce60f5b16be3f023a4 /ui/spice-input.c
parent6e378dd214fbbae8138ff011ec3de7ddf13a445f (diff)
downloadfocaccia-qemu-3d0db3e74d818ba43c62cdfb3220e551f4f5ae37.tar.gz
focaccia-qemu-3d0db3e74d818ba43c62cdfb3220e551f4f5ae37.zip
spapr_rng: disable hotpluggability
It is currently possible to hotplug a spapr_rng device but QEMU crashes
when we try to hot unplug:

ERROR:hw/core/qdev.c:295:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted

This happens because spapr_rng isn't plugged to any bus and sPAPR does
not provide hotplug support for it: qdev_get_hotplug_handler() hence
return NULL and we hit the assertion.

And anyway, it doesn't make much sense to unplug this device since hcalls
cannot be unregistered. Even the idea of hotplugging a RNG device instead
of declaring it on the QEMU command line looks weird.

This patch simply disables hotpluggability for the spapr-rng class.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'ui/spice-input.c')
0 files changed, 0 insertions, 0 deletions