summary refs log tree commit diff stats
path: root/util/qemu-error.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-12-17 17:35:16 +0100
committerMarkus Armbruster <armbru@redhat.com>2016-01-13 11:58:58 +0100
commitc72fbf98cb243df53b92081dd9daae21c7ea0d46 (patch)
treefaf8abf945d3f3ffac2a4d37c3254ccb24e929bd /util/qemu-error.c
parent7b55044f9d96ec518e7ab58bd8a3637b52a35f79 (diff)
downloadfocaccia-qemu-c72fbf98cb243df53b92081dd9daae21c7ea0d46.tar.gz
focaccia-qemu-c72fbf98cb243df53b92081dd9daae21c7ea0d46.zip
sysbus: Don't use hw_error() in machine_init_done_notifiers
platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
fail.  They run in machine_init_done_notifiers, via
platform_bus_init_notify() and link_sysbus_device().  Printing CPU
registers is not helpful there.

Replace hw_error() by error_report(); exit(1).  If these are
programming errors, it should be replaced by an assertion instead.

While there, observe that both functions always return 0, and
link_sysbus_device() ignores the return value.  Change them to void.

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1450370121-5768-9-git-send-email-armbru@redhat.com>
Diffstat (limited to 'util/qemu-error.c')
0 files changed, 0 insertions, 0 deletions