summary refs log tree commit diff stats
path: root/util/qemu-option.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2021-06-10 10:50:26 +0200
committerLaurent Vivier <laurent@vivier.eu>2021-07-09 18:42:46 +0200
commit0849cb547844b7205af01455b82dc54956c978a9 (patch)
treebbdff38e80b53d35d22615856e720b4e8e9c70e2 /util/qemu-option.c
parent05de778b5b8ab0b402996769117b88c7ea5c7c61 (diff)
downloadfocaccia-qemu-0849cb547844b7205af01455b82dc54956c978a9.tar.gz
focaccia-qemu-0849cb547844b7205af01455b82dc54956c978a9.zip
qemu-option: Drop dead assertion
Commit c6ecec43b2 "qemu-option: Check return value instead of @err
where convenient" simplified

    opts = qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1,
                            &local_err);
    if (local_err) {
        error_propagate(errp, local_err);
        return NULL;
    }

to

    opts = qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1, errp);
    if (!opts) {
        return NULL;
    }

but neglected to delete

    assert(opts != NULL);

Do that now.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210610085026.436081-1-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'util/qemu-option.c')
-rw-r--r--util/qemu-option.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/util/qemu-option.c b/util/qemu-option.c
index ee78e42216..61cb4a97bd 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -997,8 +997,6 @@ QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict,
         return NULL;
     }
 
-    assert(opts != NULL);
-
     for (entry = qdict_first(qdict);
          entry;
          entry = qdict_next(qdict, entry)) {