summary refs log tree commit diff stats
path: root/util/qemu-option.c
diff options
context:
space:
mode:
authorZenghui Yu <yuzenghui@huawei.com>2020-12-08 19:40:13 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2020-12-15 12:52:05 -0500
commit4054adbdd2f66d78f73cdce0092eb5513b3b3521 (patch)
treed37d9e0599b9990f6afaec4afc047464db4a0996 /util/qemu-option.c
parentcfd4e36352d4426221aa94da44a172da1aaa741b (diff)
downloadfocaccia-qemu-4054adbdd2f66d78f73cdce0092eb5513b3b3521.tar.gz
focaccia-qemu-4054adbdd2f66d78f73cdce0092eb5513b3b3521.zip
kvm: Take into account the unaligned section size when preparing bitmap
The kernel KVM_CLEAR_DIRTY_LOG interface has align requirement on both the
start and the size of the given range of pages. We have been careful to
handle the unaligned cases when performing CLEAR on one slot. But it seems
that we forget to take the unaligned *size* case into account when
preparing bitmap for the interface, and we may end up clearing dirty status
for pages outside of [start, start + size).

If the size is unaligned, let's go through the slow path to manipulate a
temp bitmap for the interface so that we won't bother with those unaligned
bits at the end of bitmap.

I don't think this can happen in practice since the upper layer would
provide us with the alignment guarantee. I'm not sure if kvm-all could rely
on it. And this patch is mainly intended to address correctness of the
specific algorithm used inside kvm_log_clear_one_slot().

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Message-Id: <20201208114013.875-1-yuzenghui@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'util/qemu-option.c')
0 files changed, 0 insertions, 0 deletions