summary refs log tree commit diff stats
path: root/util/qemu-timer-common.c
diff options
context:
space:
mode:
authorLev Kujawski <lkujaw@member.fsf.org>2022-07-07 03:11:36 +0000
committerKevin Wolf <kwolf@redhat.com>2022-09-30 18:43:44 +0200
commit3195c9e6abe96b367a671474e850ae3f89781880 (patch)
tree4709c745c0b9150476b664ab3a7e61718791cc14 /util/qemu-timer-common.c
parentecfcf71314bc1548f387a035e1061296ec8f4ec3 (diff)
downloadfocaccia-qemu-3195c9e6abe96b367a671474e850ae3f89781880.tar.gz
focaccia-qemu-3195c9e6abe96b367a671474e850ae3f89781880.zip
hw/ide/core: Clear LBA and drive bits for EXECUTE DEVICE DIAGNOSTIC
Prior to this patch, cmd_exec_dev_diagnostic relied upon
ide_set_signature to clear the device register.  While the
preservation of the drive bit by ide_set_signature is necessary for
the DEVICE RESET, IDENTIFY DEVICE, and READ SECTOR commands,
ATA/ATAPI-6 specifies that "DEV shall be cleared to zero" for EXECUTE
DEVICE DIAGNOSTIC.

This deviation was uncovered by the ATACT Device Testing Program
written by Hale Landis.

Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
Message-Id: <20220707031140.158958-3-lkujaw@member.fsf.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'util/qemu-timer-common.c')
0 files changed, 0 insertions, 0 deletions