diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-10-29 10:33:04 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2020-11-03 19:06:22 +0000 |
| commit | 4b19e9b8159b5eecf8e90c81c56c1a13547e411a (patch) | |
| tree | cd0f435cda29e905d84b1ab8ed033e36f41c8e6d /util/vfio-helpers.c | |
| parent | 9e13d598843cca1cdab7b7bdcb9cc0868ebf7fed (diff) | |
| download | focaccia-qemu-4b19e9b8159b5eecf8e90c81c56c1a13547e411a.tar.gz focaccia-qemu-4b19e9b8159b5eecf8e90c81c56c1a13547e411a.zip | |
block/nvme: Fix use of write-only doorbells page on Aarch64 arch
qemu_vfio_pci_map_bar() calls mmap(), and mmap(2) states:
'offset' must be a multiple of the page size as returned
by sysconf(_SC_PAGE_SIZE).
In commit f68453237b9 we started to use an offset of 4K which
broke this contract on Aarch64 arch.
Fix by mapping at offset 0, and and accessing doorbells at offset=4K.
Fixes: f68453237b9 ("block/nvme: Map doorbells pages write-only")
Reported-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201029093306.1063879-24-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Diffstat (limited to 'util/vfio-helpers.c')
0 files changed, 0 insertions, 0 deletions