summary refs log tree commit diff stats
path: root/util
diff options
context:
space:
mode:
authorFabiano Rosas <farosas@suse.de>2024-06-17 15:57:24 -0300
committerFabiano Rosas <farosas@suse.de>2024-06-21 09:47:21 -0300
commit960f29b347ad34a53580fa822083d51ba7851b7b (patch)
treeb913174889de6fdc2205d4d1e5c21ae6994a560c /util
parent881172f3f9dfe5764e7cb8983e5a660b93224d0c (diff)
downloadfocaccia-qemu-960f29b347ad34a53580fa822083d51ba7851b7b.tar.gz
focaccia-qemu-960f29b347ad34a53580fa822083d51ba7851b7b.zip
monitor: Report errors from monitor_fdset_dup_fd_add
I'm keeping the EACCES because callers expect to be able to look at
errno.

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Diffstat (limited to 'util')
-rw-r--r--util/osdep.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/util/osdep.c b/util/osdep.c
index 756de9a745..5bbfdfac7a 100644
--- a/util/osdep.c
+++ b/util/osdep.c
@@ -310,7 +310,6 @@ qemu_open_internal(const char *name, int flags, mode_t mode, Error **errp)
     /* Attempt dup of fd from fd set */
     if (strstart(name, "/dev/fdset/", &fdset_id_str)) {
         int64_t fdset_id;
-        int dupfd;
 
         fdset_id = qemu_parse_fdset(fdset_id_str);
         if (fdset_id == -1) {
@@ -319,14 +318,7 @@ qemu_open_internal(const char *name, int flags, mode_t mode, Error **errp)
             return -1;
         }
 
-        dupfd = monitor_fdset_dup_fd_add(fdset_id, flags);
-        if (dupfd == -1) {
-            error_setg_errno(errp, errno, "Could not dup FD for %s flags %x",
-                             name, flags);
-            return -1;
-        }
-
-        return dupfd;
+        return monitor_fdset_dup_fd_add(fdset_id, flags, errp);
     }
 #endif