summary refs log tree commit diff stats
path: root/results/classifier/105/socket/1075339
diff options
context:
space:
mode:
authorChristian Krinitsin <mail@krinitsin.com>2025-06-03 12:04:13 +0000
committerChristian Krinitsin <mail@krinitsin.com>2025-06-03 12:04:13 +0000
commit256709d2eb3fd80d768a99964be5caa61effa2a0 (patch)
tree05b2352fba70923126836a64b6a0de43902e976a /results/classifier/105/socket/1075339
parent2ab14fa96a6c5484b5e4ba8337551bb8dcc79cc5 (diff)
downloadqemu-analysis-256709d2eb3fd80d768a99964be5caa61effa2a0.tar.gz
qemu-analysis-256709d2eb3fd80d768a99964be5caa61effa2a0.zip
add new classifier result
Diffstat (limited to 'results/classifier/105/socket/1075339')
-rw-r--r--results/classifier/105/socket/107533927
1 files changed, 27 insertions, 0 deletions
diff --git a/results/classifier/105/socket/1075339 b/results/classifier/105/socket/1075339
new file mode 100644
index 000000000..e4b977fee
--- /dev/null
+++ b/results/classifier/105/socket/1075339
@@ -0,0 +1,27 @@
+socket: 0.815
+mistranslation: 0.768
+semantic: 0.637
+device: 0.551
+other: 0.477
+network: 0.424
+instruction: 0.374
+boot: 0.362
+graphic: 0.355
+vnc: 0.192
+KVM: 0.149
+assembly: 0.049
+
+linux-user emulation of setsockopt ignores optlen
+
+setsockopt always treats the argument as a 4-byte int. This breaks timeout options (for which it's an 8- or 16-byte timeval structure, depending on word size) and possibly other socket options. int is probably a safe default, but options whose values are other types need special-case conversion code.
+
+Agreed; we would ideally be more careful to return ENOTSUP for options we don't know we handle correctly. It would be useful if you said which particular options you were interested in and provided a test case...
+
+
+I mentioned the timeout options (send/receive timeout) which are the
+ones I was interested in.
+
+
+We fixed our setsockopt emulation to correctly convert timeval parameters for SO_RCVTIMEO and SO_SNDTIMEO back in 2013.
+
+