summary refs log tree commit diff stats
path: root/results/classifier/deepseek-1/output/files/1879998
diff options
context:
space:
mode:
authorChristian Krinitsin <mail@krinitsin.com>2025-07-03 19:39:53 +0200
committerChristian Krinitsin <mail@krinitsin.com>2025-07-03 19:39:53 +0200
commitdee4dcba78baf712cab403d47d9db319ab7f95d6 (patch)
tree418478faf06786701a56268672f73d6b0b4eb239 /results/classifier/deepseek-1/output/files/1879998
parent4d9e26c0333abd39bdbd039dcdb30ed429c475ba (diff)
downloadqemu-analysis-dee4dcba78baf712cab403d47d9db319ab7f95d6.tar.gz
qemu-analysis-dee4dcba78baf712cab403d47d9db319ab7f95d6.zip
restructure results
Diffstat (limited to 'results/classifier/deepseek-1/output/files/1879998')
-rw-r--r--results/classifier/deepseek-1/output/files/187999835
1 files changed, 0 insertions, 35 deletions
diff --git a/results/classifier/deepseek-1/output/files/1879998 b/results/classifier/deepseek-1/output/files/1879998
deleted file mode 100644
index 5d60613da..000000000
--- a/results/classifier/deepseek-1/output/files/1879998
+++ /dev/null
@@ -1,35 +0,0 @@
-
-Bad check for return value of mmap()
-
-In
-./roms/skiboot/extract-gcov.c
-there is this code:
-
-        addr = mmap(NULL, sb.st_size, PROT_READ, MAP_PRIVATE, fd, 0);
-        assert(addr != NULL);
-
-This check is wrong, mmap never returns NULL, on errors it returns MAP_FAILED (or -1). (Also sidenote: asserts usually shouldn't be used for error checking.)
-
-In
-roms/skiboot/libstb/print-container.c
-there's a similar issue:
-
-        payload = mmap(NULL, payload_st.st_size - SECURE_BOOT_HEADERS_SIZE,
-                        PROT_READ, MAP_PRIVATE, fdin, SECURE_BOOT_HEADERS_SIZE);
-        if (!payload)
-
-This if should be (payload == MAP_FAILED).
-
-Another one is in
-./roms/skiboot/libstb/create-container.c
-
-And in
-./roms/u-boot/tools/aisimage.c
-there's an mmap call that does not check the return value at all.
-
-skiboot is a separate project, we do not manage its code in the QEMU project, but just include the source code in our release tarballs since we ship the skiboot binary with QEMU. Please report these problems to the skiboot project instead:
-
- https://github.com/open-power/skiboot
-
-And concerning the mmap in roms/u-boot/, please report that issue to the U-Boot project instead: https://www.denx.de/wiki/U-Boot/
-