diff options
Diffstat (limited to 'gitlab/issues/target_missing/host_missing/accel_HVF/1571.toml')
| -rw-r--r-- | gitlab/issues/target_missing/host_missing/accel_HVF/1571.toml | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/gitlab/issues/target_missing/host_missing/accel_HVF/1571.toml b/gitlab/issues/target_missing/host_missing/accel_HVF/1571.toml deleted file mode 100644 index ee87640a6..000000000 --- a/gitlab/issues/target_missing/host_missing/accel_HVF/1571.toml +++ /dev/null @@ -1,20 +0,0 @@ -id = 1571 -title = "accel/hvf: Instance size not properly declared" -state = "opened" -created_at = "2023-04-02T19:27:47.892Z" -closed_at = "n/a" -labels = ["Bite Sized", "accel: HVF", "kind::Bug"] -url = "https://gitlab.com/qemu-project/qemu/-/issues/1571" -host-os = "macOS" -host-arch = "x86_64/ARM" -qemu-version = "Almost HEAD" -guest-os = "Any supported by HVF" -guest-arch = "x86, AARCH64" -description = """In [`include/sysemu/hvf.h`](https://gitlab.com/qemu-project/qemu/-/blob/master/include/sysemu/hvf.h#L36), `HVFState` is declared to have the QOM type `TYPE_HVF_ACCEL`; -However, when the type is registered, proper `instance_size` for it was [not declared](https://gitlab.com/qemu-project/qemu/-/blob/master/accel/hvf/hvf-accel-ops.c#L351). - -As a result, a bad workaround was introduced. That is, when [`hvf_accel_init`](https://gitlab.com/qemu-project/qemu/-/blob/master/accel/hvf/hvf-accel-ops.c#L329) is called from [`accel_init_machine`](https://gitlab.com/qemu-project/qemu/-/blob/master/accel/accel-softmmu.c#L33), an new instance of `HVFState` is allocated while we should have used the pre-allocated instance in `ms->accelerator` similar to [what KVM does](https://gitlab.com/qemu-project/qemu/-/blob/master/accel/kvm/kvm-all.c#L2381) (the code didn't do so since the allocated ([using `object_new_with_class`](https://gitlab.com/qemu-project/qemu/-/blob/master/softmmu/vl.c#L2218)) instance didn't allocate enough memory for `HVFState`). - -Eventhough the code wouldn't crash nor have any serious implication, this would leak an `AccelState` and attempts to manually manage accelerators would cause a buffer-overflow.""" -reproduce = """1. Run a HVF-accelerated VM""" -additional = """""" |