summary refs log tree commit diff stats
path: root/gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml
diff options
context:
space:
mode:
Diffstat (limited to 'gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml')
-rw-r--r--gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml59
1 files changed, 59 insertions, 0 deletions
diff --git a/gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml b/gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml
new file mode 100644
index 000000000..31a39e94a
--- /dev/null
+++ b/gitlab/issues_toml/target_missing/host_missing/accel_missing/1710.toml
@@ -0,0 +1,59 @@
+id = 1710
+title = "contrib/plugins/Makefile is not crossplatform"
+state = "closed"
+created_at = "2023-06-15T06:36:17.105Z"
+closed_at = "2024-11-06T16:59:18.940Z"
+labels = ["TCG plugins", "workflow::Triaged"]
+url = "https://gitlab.com/qemu-project/qemu/-/issues/1710"
+host-os = "macOS, Windows"
+host-arch = "-"
+qemu-version = "****"
+guest-os = "*"
+guest-arch = "n/a"
+description = """Currently `contrib/plugins/Makefile` makes multiple assumptions about paths used, compiler flags available, and library extension"""
+reproduce = """1. Compile QEMU from sources on macOS or Windows
+2. Enter `contrib/plugins`
+3. Type `make` and become sad."""
+additional = """As the rest of QEMU switched to Meson, maybe it's a good idea to do the same for plugins as well?
+
+This is what I come with myself:
+
+`meson.build`:
+```meson
+project('qemu-plugins', 'c', meson_version: '>=0.50.0')
+
+qemu_src = get_option('qemu_path')
+if qemu_src == ''
+  qemu_src = '../..'
+endif
+
+qemu_include = qemu_src + '/include/qemu'
+incdir = include_directories(qemu_include)
+
+plugins = [
+  'execlog',
+  'hotblocks',
+  'hotpages',
+  'howvec',
+  'lockstep',
+  'hwprofile',
+  'cache',
+  'drcov',
+]
+
+th = dependency('threads', required: true)
+glib = dependency('glib-2.0', required: true)
+
+foreach p: plugins
+  library(p, p + '.c',
+    include_directories: incdir,
+    dependencies: [th, glib],
+    override_options: ['b_lundef=false']
+  )
+endforeach
+```
+
+`meson_options.txt`:
+```
+option('qemu_path', type : 'string', value : '', description : 'Full path to the QEMU sources to build the plugin for')
+```"""