diff options
Diffstat (limited to 'results/classifier/105/instruction/1490886')
| -rw-r--r-- | results/classifier/105/instruction/1490886 | 64 |
1 files changed, 64 insertions, 0 deletions
diff --git a/results/classifier/105/instruction/1490886 b/results/classifier/105/instruction/1490886 new file mode 100644 index 000000000..dd5e8561f --- /dev/null +++ b/results/classifier/105/instruction/1490886 @@ -0,0 +1,64 @@ +instruction: 0.871 +network: 0.772 +device: 0.688 +graphic: 0.682 +socket: 0.679 +boot: 0.568 +vnc: 0.548 +KVM: 0.539 +semantic: 0.435 +other: 0.423 +mistranslation: 0.340 +assembly: 0.247 + +spice-qemu-char.c Assert + +spice-qemu-char.c:173: spice_chr_add_watch: Assertion `cond == G_IO_OUT' failed. +I trace the code virtio-console.c: +ret = qemu_chr_fe_write(vcon->chr, buf, len); + trace_virtio_console_flush_buf(port->id, len, ret); + + if (ret < len) { + VirtIOSerialPortClass *k = VIRTIO_SERIAL_PORT_GET_CLASS(port); + + /* + * Ideally we'd get a better error code than just -1, but + * that's what the chardev interface gives us right now. If + * we had a finer-grained message, like -EPIPE, we could close + * this connection. + */ + if (ret < 0) + ret = 0; + if (!k->is_console) { + virtio_serial_throttle_port(port, true); + if (!vcon->watch) { + vcon->watch = qemu_chr_fe_add_watch(vcon->chr, + G_IO_OUT|G_IO_HUP, + chr_write_unblocked, vcon); + } + } + } +and spice-qemu-char.c in function:spice_chr_add_watch +assert(cond == G_IO_OUT); +so run in this code,will trigger this assert. + +My qemu version is 2.3.0 and spice-server version is 0.12.5 + +called param is G_IO_OUT|G_IO_HUP,but assert (cond == G_IO_OUT) + +I think this is fixed by: + +commit f7a8beb5e6a13dc924895244777d9ef08b23b367 +Author: Marc-André Lureau <email address hidden> +Date: Thu May 28 15:04:58 2015 +0200 + + spice: fix spice_chr_add_watch() pre-condition + + Since e02bc6de30c44fd668dc0d6e1cd1804f2eed3ed3, add_watch() is called + with G_IO_HUP. Even if spice-qemu-char ignores this flag, the + precondition must be changed. + + https://bugzilla.redhat.com/show_bug.cgi?id=1128992 + +Which is in 2.4.0 + |