1 files changed, 72 insertions, 0 deletions
diff --git a/results/classifier/105/other/1856706 b/results/classifier/105/other/1856706
new file mode 100644
index 000000000..4a7d27b33
--- /dev/null
+++ b/results/classifier/105/other/1856706
@@ -0,0 +1,72 @@
+other: 0.773
+device: 0.684
+socket: 0.683
+network: 0.661
+instruction: 0.539
+vnc: 0.538
+boot: 0.522
+semantic: 0.517
+mistranslation: 0.491
+assembly: 0.460
+graphic: 0.457
+KVM: 0.447
+
+target/mips/op_helper.c:971:duplicated branches ?
+
+qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has identical branches [-Wduplicated-branches]
+
+Source code is
+
+   if (other_tc == other->current_tc) {
+        tccause = other->CP0_Cause;
+    } else {
+        tccause = other->CP0_Cause;
+    }
+
+Possible cut'n'paste error ?
+
+On Tue, 17 Dec. 2019, 09:28 Thomas Huth, <email address hidden> wrote:
+
+> On 17/12/2019 14.25, dcb wrote:
+> > Public bug reported:
+> >
+> > qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
+> > identical branches [-Wduplicated-branches]
+> >
+> > Source code is
+> >
+> >    if (other_tc == other->current_tc) {
+> >         tccause = other->CP0_Cause;
+> >     } else {
+> >         tccause = other->CP0_Cause;
+> >     }
+> >
+> > Possible cut'n'paste error ?
+>
+>  Hi Edgar,
+>
+> you added the code in 2011 ... do you still remember the details here,
+> whether that was on purpose or whether it should look differently?
+>
+>  Thomas
+>
+
+
+Hi Thomas,
+
+Sorry but I barely recall yesterday, 2011 was a long time ago... It does
+look weird.
+
+IIRC smp was kinda of working but the multithreading support wasn't. Some
+of these paths were probably not tested too much at the time.
+
+Cheers,
+Edgar
+
+>
+>
+
+
+Patch has been included here:
+https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9788e8c9b64e4cebb01
+