summary refs log tree commit diff stats
path: root/results/classifier/118/review/1103868
diff options
context:
space:
mode:
Diffstat (limited to 'results/classifier/118/review/1103868')
-rw-r--r--results/classifier/118/review/1103868123
1 files changed, 123 insertions, 0 deletions
diff --git a/results/classifier/118/review/1103868 b/results/classifier/118/review/1103868
new file mode 100644
index 000000000..0ac718292
--- /dev/null
+++ b/results/classifier/118/review/1103868
@@ -0,0 +1,123 @@
+architecture: 0.908
+files: 0.900
+permissions: 0.887
+device: 0.877
+PID: 0.857
+socket: 0.820
+user-level: 0.806
+arm: 0.802
+x86: 0.802
+performance: 0.773
+mistranslation: 0.762
+debug: 0.761
+peripherals: 0.758
+kernel: 0.756
+register: 0.741
+vnc: 0.736
+ppc: 0.723
+semantic: 0.721
+risc-v: 0.717
+network: 0.713
+boot: 0.698
+graphic: 0.684
+virtual: 0.684
+assembly: 0.637
+TCG: 0.633
+hypervisor: 0.622
+VMM: 0.332
+KVM: 0.326
+i386: 0.225
+--------------------
+x86: 0.981
+virtual: 0.824
+hypervisor: 0.803
+vnc: 0.667
+debug: 0.367
+device: 0.050
+register: 0.027
+files: 0.025
+PID: 0.021
+TCG: 0.017
+user-level: 0.010
+kernel: 0.010
+assembly: 0.005
+VMM: 0.005
+ppc: 0.004
+network: 0.004
+boot: 0.004
+KVM: 0.003
+semantic: 0.003
+risc-v: 0.003
+socket: 0.003
+peripherals: 0.003
+performance: 0.002
+i386: 0.002
+graphic: 0.002
+permissions: 0.002
+architecture: 0.002
+arm: 0.001
+mistranslation: 0.001
+
+drive_mirror crashes on full disk copy of a resized disk with a backing file
+
+This bug was discovered using libvirt on ubuntu with a build of qemu 1.3 but it is trivailly reproducible with the curent git version.
+
+Repro steps:
+
+qemu-img create -f qcow2 base 32M
+qemu-img create -f qcow2 -o backing_file=base disk
+qemu-img resize /home/vishvananda/disk 64M
+qemu-system-x86_64 -drive file=disk,id=vda -vnc :1 -monitor stdio
+QEMU 1.3.0 monitor - type 'help' for more information
+(qemu) drive_mirror -f vda test
+Formatting 'test', fmt=qcow2 size=67108864 encryption=off cluster_size=65536 lazy_refcounts=off 
+qemu-system-x86_64: /build/buildd/qemu-1.3.0+dfsg/block/mirror.c:129: mirror_run: Assertion `n > 0' failed.
+Aborted
+
+Note that the command works just fine if the front image is not resized:
+
+qemu-img create -f qcow2 base 32M
+qemu-img create -f qcow2 -o backing_file=base disk
+qemu-system-x86_64 -drive file=disk,id=vda -vnc :1 -monitor stdio
+
+or if the backing file is resized as well:
+
+qemu-img create -f qcow2 base 32M
+qemu-img create -f qcow2 -o backing_file=base disk
+qemu-img resize /home/vishvananda/disk 64M
+qemu-img resize /home/vishvananda/base 64M
+qemu-system-x86_64 -drive file=disk,id=vda -vnc :1 -monitor stdio
+
+or if we don't use -f when creating the mirror:
+
+QEMU 1.3.0 monitor - type 'help' for more information
+(qemu) drive_mirror vda test
+Formatting 'test', fmt=qcow2 size=33554432 backing_file='base' backing_fmt='qcow2' encryption=off cluster_size=65536 lazy_refcounts=off 
+
+although in this final case the mirror is created the same size as the backing file which seems wrong:
+
+qemu-img info test
+image: test
+file format: qcow2
+virtual size: 32M (33554432 bytes)
+disk size: 196K
+cluster_size: 65536
+backing file: base
+backing file format: qcow2
+
+separated the final size issue into a separate bug here:
+
+https://bugs.launchpad.net/qemu/+bug/1103903
+
+Haven't found a good workaround for this. Best I've come up with is to use the workaround described in the other bug and then coalesce the files afterwards via qemu-img convert
+
+
+
+Reformatted patch and submitted upstream:
+
+http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg04585.html
+
+Patch has been included here:
+http://git.qemu.org/?p=qemu.git;a=commitdiff;h=63ba17d39f1a8d262b31e
+... so I think it's OK to close this bug now.
+