diff options
Diffstat (limited to 'results/scraper/fex/3631')
| -rw-r--r-- | results/scraper/fex/3631 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/results/scraper/fex/3631 b/results/scraper/fex/3631 new file mode 100644 index 000000000..3b1ddc182 --- /dev/null +++ b/results/scraper/fex/3631 @@ -0,0 +1,4 @@ +Blocks are not physically removed +I haven't looked into the algo in detail but it feels to me like we should not ignore the return value of `std::remove`. This does not physically remove the Predecessor, simply moves it to another place. We should probably use `std::erase` here. See https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom + +https://github.com/FEX-Emu/FEX/blame/c5f8ea58e91df8ad73a8efb6ae2b0206662ea24c/FEXCore/Source/Interface/IR/Passes/RAValidation.cpp#L246 \ No newline at end of file |