1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
|
other: 0.877
semantic: 0.825
instruction: 0.816
mistranslation: 0.811
[Qemu-devel] [BUG] Monitor QMP is broken ?
Hello!
I have updated my qemu to the recent version and it seems to have lost
compatibility with
libvirt. The error message is:
--- cut ---
internal error: unable to execute QEMU command 'qmp_capabilities': QMP input
object member
'id' is unexpected
--- cut ---
What does it mean? Is it intentional or not?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Hello!
>
I have updated my qemu to the recent version and it seems to have lost
>
compatibility
with
>
libvirt. The error message is:
>
--- cut ---
>
internal error: unable to execute QEMU command 'qmp_capabilities': QMP input
>
object
>
member
>
'id' is unexpected
>
--- cut ---
>
What does it mean? Is it intentional or not?
I have found the problem. It is caused by commit
65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to use the
removed
asynchronous interface but it still feeds in JSONs with 'id' field set to
something. So i
think the related fragment in qmp_check_input_obj() function should be brought
back
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
On Fri, Jun 05, 2015 at 04:58:46PM +0300, Pavel Fedin wrote:
>
Hello!
>
>
> I have updated my qemu to the recent version and it seems to have lost
>
> compatibility
>
with
>
> libvirt. The error message is:
>
> --- cut ---
>
> internal error: unable to execute QEMU command 'qmp_capabilities': QMP
>
> input object
>
> member
>
> 'id' is unexpected
>
> --- cut ---
>
> What does it mean? Is it intentional or not?
>
>
I have found the problem. It is caused by commit
>
65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to use the
>
removed
>
asynchronous interface but it still feeds in JSONs with 'id' field set to
>
something. So i
>
think the related fragment in qmp_check_input_obj() function should be
>
brought back
If QMP is rejecting the 'id' parameter that is a regression bug.
[quote]
The QMP spec says
2.3 Issuing Commands
--------------------
The format for command execution is:
{ "execute": json-string, "arguments": json-object, "id": json-value }
Where,
- The "execute" member identifies the command to be executed by the Server
- The "arguments" member is used to pass any arguments required for the
execution of the command, it is optional when no arguments are
required. Each command documents what contents will be considered
valid when handling the json-argument
- The "id" member is a transaction identification associated with the
command execution, it is optional and will be part of the response if
provided. The "id" member can be any json-value, although most
clients merely use a json-number incremented for each successive
command
2.4 Commands Responses
----------------------
There are two possible responses which the Server will issue as the result
of a command execution: success or error.
2.4.1 success
-------------
The format of a success response is:
{ "return": json-value, "id": json-value }
Where,
- The "return" member contains the data returned by the command, which
is defined on a per-command basis (usually a json-object or
json-array of json-objects, but sometimes a json-number, json-string,
or json-array of json-strings); it is an empty json-object if the
command does not return data
- The "id" member contains the transaction identification associated
with the command execution if issued by the Client
[/quote]
And as such, libvirt chose to /always/ send an 'id' parameter in all
commands it issues.
We don't however validate the id in the reply, though arguably we
should have done so.
Regards,
Daniel
--
|:
http://berrange.com
-o-
http://www.flickr.com/photos/dberrange/
:|
|:
http://libvirt.org
-o-
http://virt-manager.org
:|
|:
http://autobuild.org
-o-
http://search.cpan.org/~danberr/
:|
|:
http://entangle-photo.org
-o-
http://live.gnome.org/gtk-vnc
:|
"Daniel P. Berrange" <address@hidden> writes:
>
On Fri, Jun 05, 2015 at 04:58:46PM +0300, Pavel Fedin wrote:
>
> Hello!
>
>
>
> > I have updated my qemu to the recent version and it seems to have
>
> > lost compatibility
>
> with
>
> > libvirt. The error message is:
>
> > --- cut ---
>
> > internal error: unable to execute QEMU command 'qmp_capabilities':
>
> > QMP input object
>
> > member
>
> > 'id' is unexpected
>
> > --- cut ---
>
> > What does it mean? Is it intentional or not?
>
>
>
> I have found the problem. It is caused by commit
>
> 65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to
>
> use the removed
>
> asynchronous interface but it still feeds in JSONs with 'id' field
>
> set to something. So i
>
> think the related fragment in qmp_check_input_obj() function should
>
> be brought back
>
>
If QMP is rejecting the 'id' parameter that is a regression bug.
It is definitely a regression, my fault, and I'll get it fixed a.s.a.p.
[...]
|