path: root/classification_output/02/other/21221931

other: 0.979
instruction: 0.974
semantic: 0.967
boot: 0.947
mistranslation: 0.933

[BUG] qemu git error with virgl

Hello,

i can't start any system if i use virgl. I get the following error:
qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_create: Assertion
`con->gl' failed.
./and.sh: line 27: 3337167 Aborted                 qemu-x86_64 -m 4096
-smp cores=4,sockets=1 -cpu host -machine pc-q35-4.0,accel=kvm -device
virtio-vga,virgl=on,xres=1280,yres=800 -display sdl,gl=on -device
intel-hda,id=sound0,msi=on -device
hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 -device qemu-xhci,id=xhci
-device usb-tablet,bus=xhci.0 -net
nic,macaddr=52:54:00:12:34:62,model=e1000 -net
tap,ifname=$INTERFACE,script=no,downscript=no -drive
file=/media/daten2/image/lineageos.qcow2,if=virtio,index=1,media=disk,cache=none,aio=threads
Set 'tap3' nonpersistent

i have bicected the issue:

towo:Defiant> git bisect good
b4e1a342112e50e05b609e857f38c1f2b7aafdc4 is the first bad commit
commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Tue Oct 27 08:44:23 2020 -0400

    vl: remove separate preconfig main_loop
    Move post-preconfig initialization to the x-exit-preconfig. If
preconfig
    is not requested, just exit preconfig mode immediately with the QMP
    command.

    As a result, the preconfig loop will run with accel_setup_post
    and os_setup_post restrictions (xen_restrict, chroot, etc.)
    already done.

    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

 include/sysemu/runstate.h |  1 -
 monitor/qmp-cmds.c        |  9 -----
 softmmu/vl.c              | 95
++++++++++++++++++++---------------------------
 3 files changed, 41 insertions(+), 64 deletions(-)

Regards,

Torsten Wohlfarth

Cc'ing Gerd + patch author/reviewer.

On 1/2/21 2:11 PM, Torsten Wohlfarth wrote:
>
Hello,
>
>
i can't start any system if i use virgl. I get the following error:
>
>
qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_create: Assertion
>
`con->gl' failed.
>
./and.sh: line 27: 3337167 Aborted                 qemu-x86_64 -m 4096
>
-smp cores=4,sockets=1 -cpu host -machine pc-q35-4.0,accel=kvm -device
>
virtio-vga,virgl=on,xres=1280,yres=800 -display sdl,gl=on -device
>
intel-hda,id=sound0,msi=on -device
>
hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 -device qemu-xhci,id=xhci
>
-device usb-tablet,bus=xhci.0 -net
>
nic,macaddr=52:54:00:12:34:62,model=e1000 -net
>
tap,ifname=$INTERFACE,script=no,downscript=no -drive
>
file=/media/daten2/image/lineageos.qcow2,if=virtio,index=1,media=disk,cache=none,aio=threads
>
>
Set 'tap3' nonpersistent
>
>
i have bicected the issue:
>
>
towo:Defiant> git bisect good
>
b4e1a342112e50e05b609e857f38c1f2b7aafdc4 is the first bad commit
>
commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
>
Author: Paolo Bonzini <pbonzini@redhat.com>
>
Date:   Tue Oct 27 08:44:23 2020 -0400
>
>
    vl: remove separate preconfig main_loop
>
>
    Move post-preconfig initialization to the x-exit-preconfig. If
>
preconfig
>
    is not requested, just exit preconfig mode immediately with the QMP
>
    command.
>
>
    As a result, the preconfig loop will run with accel_setup_post
>
    and os_setup_post restrictions (xen_restrict, chroot, etc.)
>
    already done.
>
>
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
 include/sysemu/runstate.h |  1 -
>
 monitor/qmp-cmds.c        |  9 -----
>
 softmmu/vl.c              | 95
>
++++++++++++++++++++---------------------------
>
 3 files changed, 41 insertions(+), 64 deletions(-)
>
>
Regards,
>
>
Torsten Wohlfarth
>
>
>

On Sun, 3 Jan 2021 18:28:11 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

>
Cc'ing Gerd + patch author/reviewer.
>
>
On 1/2/21 2:11 PM, Torsten Wohlfarth wrote:
>
> Hello,
>
>
>
> i can't start any system if i use virgl. I get the following error:
>
>
>
> qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_create: Assertion
>
> `con->gl' failed.
Does following fix issue:
  [PULL 12/55] vl: initialize displays _after_ exiting preconfiguration

>
> ./and.sh: line 27: 3337167 Aborted                 qemu-x86_64 -m 4096
>
> -smp cores=4,sockets=1 -cpu host -machine pc-q35-4.0,accel=kvm -device
>
> virtio-vga,virgl=on,xres=1280,yres=800 -display sdl,gl=on -device
>
> intel-hda,id=sound0,msi=on -device
>
> hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 -device qemu-xhci,id=xhci
>
> -device usb-tablet,bus=xhci.0 -net
>
> nic,macaddr=52:54:00:12:34:62,model=e1000 -net
>
> tap,ifname=$INTERFACE,script=no,downscript=no -drive
>
> file=/media/daten2/image/lineageos.qcow2,if=virtio,index=1,media=disk,cache=none,aio=threads
>
>
>
> Set 'tap3' nonpersistent
>
>
>
> i have bicected the issue:
>
>
>
> towo:Defiant> git bisect good
>
> b4e1a342112e50e05b609e857f38c1f2b7aafdc4 is the first bad commit
>
> commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
>
> Author: Paolo Bonzini <pbonzini@redhat.com>
>
> Date:   Tue Oct 27 08:44:23 2020 -0400
>
>
>
>     vl: remove separate preconfig main_loop
>
>
>
>     Move post-preconfig initialization to the x-exit-preconfig. If
>
> preconfig
>
>     is not requested, just exit preconfig mode immediately with the QMP
>
>     command.
>
>
>
>     As a result, the preconfig loop will run with accel_setup_post
>
>     and os_setup_post restrictions (xen_restrict, chroot, etc.)
>
>     already done.
>
>
>
>     Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
>
>  include/sysemu/runstate.h |  1 -
>
>  monitor/qmp-cmds.c        |  9 -----
>
>  softmmu/vl.c              | 95
>
> ++++++++++++++++++++---------------------------
>
>  3 files changed, 41 insertions(+), 64 deletions(-)
>
>
>
> Regards,
>
>
>
> Torsten Wohlfarth
>
>
>
>
>
>
>
>

Hi Igor,

yes, that fixes my issue.

Regards, Torsten

Am 04.01.21 um 19:50 schrieb Igor Mammedov:
On Sun, 3 Jan 2021 18:28:11 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
Cc'ing Gerd + patch author/reviewer.

On 1/2/21 2:11 PM, Torsten Wohlfarth wrote:
Hello,

i can't start any system if i use virgl. I get the following error:

qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_create: Assertion
`con->gl' failed.
Does following fix issue:
   [PULL 12/55] vl: initialize displays _after_ exiting preconfiguration
./and.sh: line 27: 3337167 Aborted                 qemu-x86_64 -m 4096
-smp cores=4,sockets=1 -cpu host -machine pc-q35-4.0,accel=kvm -device
virtio-vga,virgl=on,xres=1280,yres=800 -display sdl,gl=on -device
intel-hda,id=sound0,msi=on -device
hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 -device qemu-xhci,id=xhci
-device usb-tablet,bus=xhci.0 -net
nic,macaddr=52:54:00:12:34:62,model=e1000 -net
tap,ifname=$INTERFACE,script=no,downscript=no -drive
file=/media/daten2/image/lineageos.qcow2,if=virtio,index=1,media=disk,cache=none,aio=threads

Set 'tap3' nonpersistent

i have bicected the issue:
towo:Defiant> git bisect good
b4e1a342112e50e05b609e857f38c1f2b7aafdc4 is the first bad commit
commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Tue Oct 27 08:44:23 2020 -0400

     vl: remove separate preconfig main_loop

     Move post-preconfig initialization to the x-exit-preconfig. If
preconfig
     is not requested, just exit preconfig mode immediately with the QMP
     command.

     As a result, the preconfig loop will run with accel_setup_post
     and os_setup_post restrictions (xen_restrict, chroot, etc.)
     already done.

     Reviewed-by: Igor Mammedov <imammedo@redhat.com>
     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

  include/sysemu/runstate.h |  1 -
  monitor/qmp-cmds.c        |  9 -----
  softmmu/vl.c              | 95
++++++++++++++++++++---------------------------
  3 files changed, 41 insertions(+), 64 deletions(-)

Regards,

Torsten Wohlfarth