summary refs log tree commit diff stats
path: root/results/classifier/accel-gemma3:12b/kvm/1624726
blob: 02a46c7a8809dd483d0944484e858a40e31a8afc (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
Integrator/CP regression after QOM'ification of integratorcp.c

The following command line no longer works (i.e. the guest does not boot) with QEMU 2.7.0:

    qemu-system-arm -M integratorcp -m 128M -kernel HelenOS-0.6.0-arm32-integratorcp.boot

The HelenOS image can be downloaded here:

    http://www.helenos.org/releases/HelenOS-0.6.0-arm32-integratorcp.boot

I did git bisect and came to this revision:

a1f42e0c9abc1028a8bb8686dbb3749fcd2d18e8 is the first bad commit
commit a1f42e0c9abc1028a8bb8686dbb3749fcd2d18e8
Author: xiaoqiang.zhao <zxq_yx_007@163.com>
Date:   Mon Mar 7 15:05:44 2016 +0800

    hw/arm: QOM'ify integratorcp.c
    
    * Drop the use of old SysBus init function and use instance_init
    * Remove the empty 'icp_pic_class_init' from Typeinfo
    
    Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
    Reviewed-by: Peter Maydell <email address hidden>
    Signed-off-by: Peter Maydell <email address hidden>

:040000 040000 b73418ea3fb69ed72438776e78786456fe4c414c b483e8579037fdae7d136b2f4ada3147bdde92f1 M	hw

Upon closer inspection, I discovered that for some reason s->memsz in integratorcm_init() is zero. In the last good revision, this value was 128. As a temporary workaround, hardcoding it to this expected value fixes the problem.