blob: 5f694a4bc9ac1939d072ef1fdae69b175d6a1c4d (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
|
wrong error for blockdev-snapshot-sync
From Laszlo Ersek:
>> + proto_drv = bdrv_find_protocol(snapshot_file);
>> if (!proto_drv) {
>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> - ret = -1;
>> - goto out;
>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
>> + return;
>> }
>
> I don't understand the logic here (based on the error message). We
> specified "format" for the case when a completely new snapshot file has
> to be created. If the file exists already, then bdrv_find_protocol()
> tries to find the driver for it. If that fails, then we must report an
> error indeed, but instead of referring to "format", we'd have to report
> the "scheme" from the beginning of "snapshot_file".
|