blob: 34aaa67186eb9724584b7d6d5c38312d4e6c59e0 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
|
device: 0.815
socket: 0.807
vnc: 0.780
instruction: 0.778
network: 0.752
graphic: 0.670
boot: 0.509
semantic: 0.472
mistranslation: 0.455
other: 0.282
assembly: 0.205
KVM: 0.026
hw/mc146818: error reading RTC_HOURS_ALARM
get_next_alarm() doesn't read the RTC_HOURS_ALARM field correctly.
- Bit 7 must be masked before conversion from BCD.
- Care must be taken to check the don't care condition before masking.
- The PM bit must be read from RTC_HOURS_ALARM, not from RTC_HOURS (as is done in convert_hour()).
Seen in commit e376a788ae130454ad5e797f60cb70d0308babb6.
The problem is obviously there, but I tried pretty hard to make it fail and couldn't so it seems latent. If you can, please provide a patch to tests/rtc-test.c that shows the bug.
[Expired for QEMU because there has been no activity for 60 days.]
|