blob: 14904f2844d6b7b05d056c67e6769e93f7ae3ed2 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
|
architecture: 0.753
performance: 0.673
device: 0.657
TCG: 0.646
mistranslation: 0.642
kernel: 0.613
network: 0.611
socket: 0.595
ppc: 0.586
files: 0.578
register: 0.517
debug: 0.486
vnc: 0.481
peripherals: 0.469
PID: 0.464
semantic: 0.463
assembly: 0.435
user-level: 0.411
graphic: 0.403
risc-v: 0.391
arm: 0.381
VMM: 0.375
x86: 0.365
virtual: 0.351
hypervisor: 0.344
permissions: 0.338
boot: 0.289
i386: 0.283
KVM: 0.192
LL/SC broken for MIPS after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f
In that commit the env->llval value is loaded as an unsigned value (instead of sign-extended as before and therefore the CMPXCHG in gen_st_cond() in translate.c fails.
I have committed a fix for this issue as https://github.com/CTSRD-CHERI/qemu/commit/a18d80c629989d002794f558968e1561edaf3dfd
An alternative solution would be to change the cmpxchg line to perform a non-sign-extended compare, i.e. replace
tcg_gen_atomic_cmpxchg_tl(t0, addr, cpu_llval, val,
eva ? MIPS_HFLAG_UM : ctx->mem_idx, tcg_mo);
with
tcg_gen_atomic_cmpxchg_tl(t0, addr, cpu_llval, val,
eva ? MIPS_HFLAG_UM : ctx->mem_idx, tcg_mo & ~MO_SIGN);
I cannot send this patch to the QEMU mailing list as I am not able to setup git-send-email.
Feel free to apply this commit or the alternative solution.
The fix I linked is incorrect, the correct URL is https://github.com/CTSRD-CHERI/qemu/commit/a833317eeb0387dcfa7615a78e74f8b48990b8bc
New patch: https://github.com/qemu/qemu/commit/6ff8dec97f1a105d0da96c67ee24c75e437df162
Patch has been merged here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ec860426dfbebe0c
|