blob: 47b3c5b664b61102d1a7e5e36cb1c6d54dc26ea6 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
device: 0.775
performance: 0.748
register: 0.699
ppc: 0.669
user-level: 0.654
socket: 0.654
mistranslation: 0.616
peripherals: 0.612
vnc: 0.599
risc-v: 0.586
semantic: 0.548
network: 0.541
graphic: 0.536
permissions: 0.520
VMM: 0.499
i386: 0.497
TCG: 0.488
arm: 0.482
boot: 0.454
x86: 0.440
architecture: 0.431
PID: 0.428
KVM: 0.421
hypervisor: 0.410
debug: 0.408
virtual: 0.392
files: 0.372
kernel: 0.363
assembly: 0.234
UHCI fails to signal stall response
When TD execution results in STALL error (STALL handshake, no stall as a result of err count reaching 0), there is no way to know about it except for checking that TD. IMO it is an error condition and it should be reflected in the status register (and issue an interrupt if enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
Hi,
Thanks for reporting this issue.
Just so you are aware: the qemu USB maintainer is probably going to be away for a while longer, so don't be too worried if this patch doesn't get looked at for 2-4 weeks.
Brad
No problem, it's not like it breaks something. This fix just makes driver development easier.
On Thu, Apr 14, 2011 at 11:35 AM, jvesely <email address hidden> wrote:
> No problem, it's not like it breaks something. This fix just makes
> driver development easier.
Please send your patch to the mailing list:
http://wiki.qemu.org/Contribute/SubmitAPatch
It may seem petty to ask this since you've already attached it to the
bug, but for QEMU development to scale and keep at a rapid pace,
everyone needs to follow these steps on submitting patches. Thanks
for your effort!
Stefan
Patch had been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8656954aedbd9995e68e
... so closing this ticket now.
|